On 07/01/2015 10:08 AM, Sudip Mukherjee wrote: > On Wed, Jul 01, 2015 at 10:50:42AM +0300, Dan Carpenter wrote: >> On Wed, Jul 01, 2015 at 12:42:24PM +0530, Sudip Mukherjee wrote: >>> On Tue, Jun 30, 2015 at 11:54:59PM +0200, Michel von Czettritz wrote: >>>> The return value of FillH2CCmd in rtl8723a_set_rssi_cmd and >>>> rtl8723a_set_raid_cmd is never checked. Both functions always return >>>> _SUCCESS. >>>> >>>> Both functions now return the return value of FillH2CCmd. >>> If they are never checked then why do we need to return some value? >>> why not make them void? >> >> They probably *should* be checked eventually? > yes, they should check the sucess/failure of the commands. If that plan > is there to check the values afterwards then the patch is correct. Both functions are currently only called by void functions, which don't check on the return values of the functions. Nonetheless I think rtl8723a_set_rssi_cmd and rtl8723a_set_raid_cmd should return correct values and another patch should take on the calling void functions error handling. As I'm not fully familiar with the inner workings of the driver, I'd leave the error handling for somebody else to implement, or would take it on later. regards Michel -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
