Search Linux Wireless

Re: [PATCH 4/6] staging: wilc1000: rework address value.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -	if ((pstrHostIfSetDrvHandler->u32Address) == (u32)NULL) {
> +	if (pstrHostIfSetDrvHandler->pAddress == NULL) {

In the linux kernel we do not like using 'p' to stand for pointer.  This
new name uses CamelCase.  Use scripts/checkpatch.pl to find obvious
mistakes like this.

The name "address" is too generic.  Use a meaningful name.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux