> Joe Perches wrote: > > On Tue, 2015-06-30 at 01:49 +0000, David Lin wrote: > > The Linux driver for WRT1900AC. The work was initially developed as > > part of openwrt effort and maintained on https://github.com/kaloz/mwlwifi. > > trivia: > > Please add terminating newlines to logging messages. > This prevents interleaving output from multiple threads. > > > diff --git a/drivers/net/wireless/mwlwifi/fwcmd.c > > b/drivers/net/wireless/mwlwifi/fwcmd.c > [] > > +static bool mwl_fwcmd_chk_adapter(struct mwl_priv *priv) { > [] > > + if (regval == 0xffffffff) { > > + wiphy_err(priv->hw->wiphy, "adapter is not existed"); > > wiphy_err(priv->hw->wiphy, "adapter is not existed\n"); > > > +static int mwl_fwcmd_wait_complete(struct mwl_priv *priv, unsigned > > +short cmd) { > [] > > + if (curr_iteration == 0) { > > + wiphy_err(priv->hw->wiphy, "cmd 0x%04x=%s timed out", > > wiphy_err(priv->hw->wiphy, "cmd 0x%04x=%s timed out\n", > > etc... > Should be modified in next patch. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
