On Wed, Jun 10, 2015 at 1:38 AM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Wed, 2015-06-03 at 23:52 +0530, Chaitanya T K wrote:
>> In case of Dynamic SMPS enable RTS/CTS for all rates.
>
>> + /* Enable RTS/CTS for below cases.
>> + * 1) Handle STA's SMPS State, if Nss > 1.
>> + * a. Use RTS_CTS, if STA is in Dynamic SMPS Mode
>> + * b. Mark Nss > 1 as unsupported, if STA is in static SMPS mode
>> + * 2) 2nd and 3rd Rates, as 1st Rate Failed.
>> + */
>> + if ((mi->sta->smps_mode == IEEE80211_SMPS_DYNAMIC &&
>> + group->streams > 1) ||
>> + offset > 0) {
>
> Indent still isn't right - the line starting with "offset" should be
> indented one less. Might also be worthwhile to just reorder the
> condition to first check for offset > 0?
Ok, i will fix the indent and also re-order the check.
> I was about to do that and apply this, but it seems the comment doesn't
> make sense since you're not doing 1b. afaict?
Yes, the comment is not applicable for this version, will remove.
Will submit V4, Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
