Search Linux Wireless

Re: [PATCH V2] ath10k: add 'cryptmode' param to support raw tx injection and sw crypto.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Liu CF/TW <cfliu.tw@xxxxxxxxx> writes:

> This change supports bypassing HW crypto engine by enabling raw Rx/Tx mode.
> This will enable use cases such as sw crypto and raw tx injection.
> This change introduces a new module param 'cryptmode'.

Please use full words, eg. sw -> software, hw -> hardware

> cryptmode:
>
>  0    Use HW crypto engine. Use native WiFi mode Tx/Rx encap

"Use hardware crypto engine with native Wi-Fi mode TX/RX encapsulation
to the firmware"

>  1    Use SW crypto engine. Use raw mode Tx/Rx encap

"Use sofware crypto engine from mac80211 with raw mode TX/RX
encapsulation to the firmware"

>  2    Supports both SW & HW crypto engine. Use raw mode Tx/Rx encap.

It's not clear how to use this. How does the user choose between SW or
HW crypto modes? Please document that fully in the commit log.

>  ath10k
>  cryptmode
>  param      Testing Status
>  -------    ---------------------------------
>     0       HW CCMP/TKIP tested ok.
>             Note: HW crypto bypass not supported by ath10k hw in native WiFi
>             mode.

What's "HW crypto bypass"? Please write the commit log so that everyone
can understand it.

>     1       - mac80211 SW crypto tested ok.
>             - raw Tx frame injection tested ok.

What does "mac80211 SW crypto tested ok" exactly mean?

>     2       HW CCMP/TKIP tested ok.
>             SW CCMP/TKIP tested ok.

How were the HW and SW modes chosen?

>             Tested raw Tx encrypted frame injection ok.

With HW or SW crypto mode?

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux