On 4 June 2015 at 17:02, Arend van Spriel <arend@xxxxxxxxxxxx> wrote:
> On 05/28/15 13:37, Rafał Miłecki wrote:
>>
>> As we plan to add support for platform NVRAM we should store direct
>> data pointer without the extra struct firmware layer. This will allow
>> us to support other sources with the only requirement being u8 buffer.
>>
>> Signed-off-by: Rafał Miłecki<zajec5@xxxxxxxxx>
>> Signed-off-by: Hante Meuleman<meuleman@xxxxxxxxxxxx>
>> Signed-off-by: Arend van Spriel<arend@xxxxxxxxxxxx>
>
>
> This look a bit contradictory. You mention below you written this from
> 'scratch' so it seems odd that it is signed off by me and Hante.
>
> You may add:
>
> Acked-by: Arend van Spriel <arend@xxxxxxxxxxxx>
Sorry, I wasn't sure how to handle it. Will fix it.
>> ---
>> Tested on router with BCM43602-s using
>> /lib/firmware/brcm/brcmfmac43602-pcie.txt
>>
>> I've written this patch from scratch, it's inspired by the dropped:
>> [PATCH 6/6] brcmfmac: Add support for host platform NVRAM loading.
>> ---
>> drivers/net/wireless/brcm80211/brcmfmac/firmware.c | 40
>> +++++++++++-----------
>> 1 file changed, 20 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/firmware.c
>> b/drivers/net/wireless/brcm80211/brcmfmac/firmware.c
>> index 7ae6461..b72df87 100644
>> --- a/drivers/net/wireless/brcm80211/brcmfmac/firmware.c
>> +++ b/drivers/net/wireless/brcm80211/brcmfmac/firmware.c
>> @@ -43,7 +43,7 @@ enum nvram_parser_state {
>> * struct nvram_parser - internal info for parser.
>> *
>> * @state: current parser state.
>> - * @fwnv: input buffer being parsed.
>> + * @data: input buffer being parsed.
>
>
> So you are not adding the data_len to the structure, which means you found
> it is not needed? Just checking as it is different from the aforementioned
> patch.
That's right.
--
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
