Hi Johannes, On Wed, Jun 3, 2015 at 5:02 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Wed, 2015-06-03 at 10:57 +1000, Julian Calaby wrote: > >> Why not add a ieee80211_hw_clear() function? Yes, it'd only be used in >> 3 places, but it'd look neater. > > Well, this was actually intentional. > > Drivers are not *supposed* to be doing this, the hardware flags are > supposed to be constant hardware description flags. The three drivers > clearing this specific but currently work OK due to the way this > particular flag is treated, but that wouldn't necessarily the case for > all of the flags; adding a _clear() function would seem to imply that > it's OK to do this, when it's really not. Ok, fair enough then. It just looked really odd to be setting it with a function in one branch of an if statement and clearing it open coded in the other. Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
