Hi Johannes, yes indeed you are right. This change is indeed not required/right. It's the special sw crypto path I'm working on in ath10k that resulted in the ieee80211_key_enable_hw_accel() code being skipped. I will fix this in ath10k driver internally. Thanks David On Mon, Jun 1, 2015 at 1:34 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Mon, 2015-06-01 at 12:38 -0700, David Liu wrote: >> The change reserves neccessary tailroom in CCMP and TKIP if required by >> drivers that sets IEEE80211_KEY_FLAG_RESERVE_TAILROOM. For example, >> ath10k HW engine in raw Tx/Rx encap mode requires SW reserve MIC/ICV space. > > I don't think this makes all that much sense. The flag is already > honoured today to actually leave enough tailroom in the SKB, and the > remainder of the code can very easily be done in the driver (in fact, if > you have a half-decent DMA engine, it's far more efficient to *not* set > this flag!) > > You're also breaking other drivers with your change. Just do it in the > driver. > > johannes > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
