Search Linux Wireless

Re: [PATCH] minstrel_ht: Use RTS_CTS when STA is in DYNAMIC SMPS mode for frames sent using Nss>1.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 2, 2015 at 2:06 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> On Mon, 2015-06-01 at 23:49 +0530, Krishna Chaitanya wrote:
>> On Thu, Jan 30, 2014 at 11:48 PM, Krishna Chaitanya
>> <chaitanya.mgit@xxxxxxxxx> wrote:
>> > On Thu, Jan 23, 2014 at 2:57 AM, Johannes Berg
>> > <johannes@xxxxxxxxxxxxxxxx> wrote:
>> >>
>> >> On Wed, 2014-01-22 at 12:27 +0530, Chaitanya T K wrote:
>> >>
>> >> > +             if (sta->smps_mode == IEEE80211_SMPS_DYNAMIC &&
>> >> > +                     minstrel_mcs_groups[i].streams > 1) {
>> >> > +                     mi->tx_flags |= IEEE80211_TX_RC_USE_RTS_CTS;
>> >> > +             } else if (sta->smps_mode == IEEE80211_SMPS_STATIC &&
>> >> > +                     minstrel_mcs_groups[i].streams > 1) {
>> >>
>> >> Your indentation is off inside the if statements. I'll have to wait for
>> >> nbd to review the patch itself, I guess.
>> >>
>> > Felix,
>> >
>> >  Any comments other than the indentation? If no, will send in the
>> > v2 with indentation fixed.
>>
>> Was checking my old submissions. This was marked as "Not Applicable" in
>> patchwork.
>>
>> Felix/Johannes,
>>
>> Can you please explain to me the meaning of the status "Not Applicable"?
>
> This patch is *ancient*, before we actually used patchwork properly ...
Ok, so you want me to send a V2 with the indentation fixed?
(or) shall i wait for Felix's review before sending V2?



-- 
Thanks,
Regards,
Chaitanya T K.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux