On 29 May 2015 at 13:39, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Fri, 2015-05-29 at 13:34 +0200, Michal Kazior wrote: > >> > I'm a bit undecided about this. Is this really the only place that >> > assumes use_4addr implies that it's a VLAN, in a context like this? >> >> Hmm.. I guess TDLS could also have use_4addr and still be a >> IFTYPE_STATION, right? > > No, TDLS can neither get here (VLAN assignment) nor does it actually set > use_4addr. The only other thing that can set use_4addr is the station > interface itself, but then we also can't get here. Good point. > That wasn't really my point though - I was thinking more along the lines > of code in rx.c, tx.c that just checks use_4addr? Not really sure. >From what I see wdev.use_4addr is always used after checking for IFTYPE_AP_VLAN. u.mgd.use_4addr on the other hand is used after checking for IFTYPE_STATION. Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
