On Thu, 2015-05-28 at 11:27 -0700, Joe Perches wrote:
> On Thu, 2015-05-28 at 18:27 +0530, Avinash Patil wrote:
> > This patch adds more logging support for association failure -
> > reason and states.
> []
> > diff --git a/drivers/net/wireless/mwifiex/fw.h b/drivers/net/wireless/mwifiex/fw.h
> []
> > @@ -419,8 +419,12 @@ enum P2P_MODES {
> > #define HS_CFG_COND_MAC_EVENT 0x00000004
> > #define HS_CFG_COND_MULTICAST_DATA 0x00000008
> >
> > -#define MWIFIEX_TIMEOUT_FOR_AP_RESP 0xfffc
> > -#define MWIFIEX_STATUS_CODE_AUTH_TIMEOUT 2
> > +#define ASSOC_ERR_AUTH_ERR_STA_FAILURE 0xFFFB
> > +#define ASSOC_ERR_ASSOC_ERR_TIMEOUT 0xFFFC
> > +#define ASSOC_ERR_ASSOC_ERR_AUTH_REFUSED 0xFFFD
>
> Is there really value in duplicating ASSOC_ERR_
> ASSOC_ERR_ASSOC_ERR_<foo>
>
>
Hmm..True.
Actually first part of message is for connection failure.
I think better format would be CONNECT_ERR_{AUTH/ASSOC}_ERR.
I will modify patch accordingly and resend v3.
-Avinash
��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
