On Tue, 2015-05-26 at 06:34 -0700, Amitkumar Karwar wrote: > Currently we are dumping driver information also inside > firmware dump API. We will call it as device dump and > dump driver and firmware data separately. Honestly, I don't think this matters. I called it 'devcoredump' or 'device' because there were people saying it might be used to dump hardware state, rather than firmware state (my original thought was to call the framework 'fwcoredump') In your driver, it's really only dumping firmware state (as far as I can tell), so I don't think the name matters. If you prefer "device dump" that's surely fine, but changing all the debugfs file names etc. just because I called the framework "devcoredump" isn't really needed I think :) Note that the framework is really also built to support "spontaneous" data collection, e.g. when the driver noticed the firmware doing something strange. You seem to support "user-triggered" only, which is perfectly reasonable again if you want it, but not necessary. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html