On Fri, 2008-04-18 at 11:49 +0200, Holger Schurig wrote: > > The code does 'if (ret) return;', because it has no option to > > return an error. > > I wrote "if (ret) return ret", not "if (ret) return;". I know you did, but I don't know why. The lbs_ethtool_get_stats() function returns void. Sebastian's patch which memsets it to zero makes sense, but it can't return an error. > I applied your second patch on top of the first one and now this > happens: > > $ ethtool -S eth1 > ethtool -S eth1 > > Which seems much better. The ultimate patch would be to provide > the result of CMD_802_GET_LOG for ethX and the result from > CMD_ACT_MESH_GET_STATS for mshX devices. > > So, if you combine both patches into one, I'd ACK from > the "firmware without mesh capabilities" perspective :-) They're separate problems, really. With or without the patch I first posted, you're getting crap back when you ask for statistics on a non-mesh device. The second patch fixes that, and stands alone. -- dwmw2 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
