Hi Robert, On Tue, Mar 31, 2015 at 05:05:53PM +0300, Robert Dolca wrote: > On Thu, Mar 26, 2015 at 2:29 AM, Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> wrote: > > Hi Robert, > > > > On Tue, Feb 24, 2015 at 12:01:47PM +0200, Robert Dolca wrote: > >> In order to communicate with the device during the setup > >> phase, the driver may need to initialize the device. After > >> the setup is done the driver should reset the device to leave > >> it in the same state that it was before the setup function > >> call. > > I would prefer not to export those symbols, but instead introduce a > > quirk bitmap to let the NCI core know that your device expects the core > > to be initialized before calling the setup ops. > > That would be done from nci_open_device(). > > As part of the initialization / firmware upgrade procedure the driver > needs to reset and initialize the NCI connection multiple times. > Having the connection initialized before calling setup is not enough. Fair enough, I am ok with exporting those symbols. BTW after looking at your setup routine, I think this is wrong: + /* Load firmware from disk */ + r = fdp_nci_request_firmware(ndev); + if (r) + goto error; You should be able to boot your NFC chipset without a local patch. If there is one, then you can try patching your device, but otherwise we should continue with the exisiting one. Cheers, Samuel. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
