On 22 May 2015 at 13:56, Michal Kazior <michal.kazior@xxxxxxxxx> wrote:
> On 22 May 2015 at 13:36, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote:
>> Michal Kazior <michal.kazior@xxxxxxxxx> writes:
[...]
>>> +void ath10k_core_get_cc_delta(struct ath10k *ar,
>>> + u32 *cc_delta, u32 *rcc_delta,
>>> + u32 cc, u32 rcc,
>>> + u32 cc_prev, u32 rcc_prev)
>>> +{
>>> + if (ar->hw_params.has_shifted_cc_wraparound && cc < cc_prev) {
>>> + cc_prev -= 0x7fffffff;
>>> + rcc *= 2;
>>> + }
>>> +
>>> + *cc_delta = cc - cc_prev;
>>> + *rcc_delta = rcc - rcc_prev;
>>> +}
>>
>> Why do you have this function in core.c? Why not in wmi.c?
>
> I don't consider this a part of WMI protocol per se. It's a logic
> which happens to be used with values delivered via WMI but is chip
> specific otherwise. For what it's worth we could be reading CC
> registers, e.g. directly via MMIO.
Now that I think about it this would fit into hw.c as well.
Michał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
