On Wed, 2015-05-20 at 15:17 +0200, Johannes Berg wrote:
> > - if (ntype != otype && netif_running(dev)) {
> > + if (ntype != otype) {
> > dev->ieee80211_ptr->use_4addr = false;
> > dev->ieee80211_ptr->mesh_id_up_len = 0;
> > wdev_lock(dev->ieee80211_ptr);
>
> I don't think that makes much sense - the code within this block really
> only makes sense when the interface *is* running, like disconnecting
> etc. Doing that when it's *not* would be entirely unexpected to the
> drivers, no?
The real problem here might be the assignment to use_4addr *before*
we've actually disconnected or anything, perhaps that should be moved?
Similarly, the mesh_id_up_len should probably be moved into the mesh
point switch case...
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
