Dear Johannes, Thanks for pointing out. I incorporated your review comment in new patch below. >From 69340d63e0c63c1ae75cdb62bf4bd04a9c961a1f Mon Sep 17 00:00:00 2001 From: rahul <rahul.jain@xxxxxxxxxxx> Date: Thu, 14 May 2015 10:21:48 +0530 Subject: [PATCH] Added 2 new Control Frames ( Beamforming Report Poll & VHT NDP Announcement) defined in 802.11ac. Beamforming Report Poll frame - This frame is used to retrieve additional feedback from the second and subsequent beamformees. The beamformer must use the Beamforming Report Poll frame. In Beamforming Report Poll, the Feedback Segment Retransmission Bitmap field indicates the requested feedback segments of a VHT Compressed Beamforming report. VHT Null Data Packet (NDP) Announcement - This frame is used by Beamformers to gain control of the channel and identiy beformees. Beamformees will respond to the NDP Announcement, while all other stations will simply defer channel access until the sounding sequence is complete Signed-off-by: rahul <rahul.jain@xxxxxxxxxxx> --- include/linux/ieee80211.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h index b9c7897..ca38616 100644 --- a/include/linux/ieee80211.h +++ b/include/linux/ieee80211.h @@ -75,6 +75,8 @@ #define IEEE80211_STYPE_ACTION 0x00D0 /* control */ +#define IEEE80211_STYPE_BEAMFORM_POLL 0x0040 +#define IEEE80211_STYPE_VHT_NDP_ANNOUCE 0x0050 #define IEEE80211_STYPE_CTL_EXT 0x0060 #define IEEE80211_STYPE_BACK_REQ 0x0080 #define IEEE80211_STYPE_BACK 0x0090 -- 1.7.9.5 Thanks -Rahul Jain ------- Original Message ------- Sender : Johannes Berg<johannes@xxxxxxxxxxxxxxxx> Date : May 20, 2015 17:44 (GMT+05:30) Title : Re: Re: [PATCH] Added 2 new Control Frames ( Beamforming Report Poll & VHT NDP Announcement) defined in 802.11ac [EDT] On Wed, 2015-05-20 at 11:51 +0000, Rahul Jain wrote: > EP-FEDC771DF4FF48A9829CB85254E29FD3 > > Dear Johannes, > > As per your request, I have updated the commit message. > This patch is first step towards further changes to be done related to 802.11ac new frames. Perhaps you should combine the two-liner with other patches then? Standalone, this isn't really worthwhile I think. > VHT Null Data Packet (NDP) Announcement - This frame is used by Beamformers to > gain control of the channel and identiy beformees. Beamformees will respond to > the NDP Announcement, while all other stations will simply defer channel access > until the sounding sequence is complete > --- Anyway you forgot S-o-b now. johannes��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f