On Tue, May 19, 2015 at 1:01 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > It looks like your patch never actually made it to the list - perhaps > test that before you add me to Cc :) Sure, i realized that after a few trails and then removed you from CC :-). >> If we receive suspend after TX path has executed >> dynamic ps disable work, the driver will be in >> ACTIVE state during suspend and even after it >> resumes. >> >> As before suspend all data packets are flushed >> it is safe to put the driver in to sleep for >> optimal power during suspend or up on resume. > > I'm not sure I get it - we always transmit a frame after resume. Let me explain the sequence of events: tx_frame: dynamic_ps_disable_work. get the chip out of power save. suspend came: dynamic ps timer is cancelled. tx queues are flushed. chip stays out of power save unless there is one more tx frame which kicks the dynamic ps timer again. -- Thanks, Regards, Chaitanya T K. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html