Search Linux Wireless

Re: [PATCH] adm8211: fix checkpatch errors for indentation and new line around switch-case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c
> index f07a618..058fb4b 100644
> --- a/drivers/net/wireless/adm8211.c
> +++ b/drivers/net/wireless/adm8211.c
> @@ -1098,14 +1098,18 @@ static void adm8211_hw_init(struct ieee80211_hw *dev)
>  		pci_read_config_byte(priv->pdev, PCI_CACHE_LINE_SIZE, &cline);
>  
>  		switch (cline) {
> -		case  0x8: reg |= (0x1 << 14);
> -			   break;
> -		case 0x16: reg |= (0x2 << 14);
> -			   break;
> -		case 0x32: reg |= (0x3 << 14);
> -			   break;
> -		  default: reg |= (0x0 << 14);
> -			   break;
> +		case  0x8:
> +			reg |= (0x1 << 14);
> +			break;
> +		case 0x16:
> +			reg |= (0x2 << 14);
> +			break;
> +		case 0x32:
> +			reg |= (0x3 << 14);
> +			break;
> +		default:
> +			reg |= (0x0 << 14);
> +			break;
>  		}
>  	}
>  

Those 0x16/0x32 hexadecimal case-selectors looking suspiciously like
decimal bits need a comment if they are in fact correct, which I doubt.

Cheers,
Peter

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux