On Wed, 2015-04-29 at 10:45 +0200, Valentin Rothberg wrote: > Thanks, I was not aware of it at all. I read the code and it seems > that if neither DYNAMIC_DEBUG nor DEBUG is defined, pr_debug() does > nothing more than to return 0. > > I am not sure what to do in this case. Somehow it seems reasonable to > me to add NFC_DEBUG to Kconfig since a considerable amount of code in > nfc seems to depend on DEBUG. A few greps tell me the first pointless reference to CONFIG_NFC_DEBUG was added in v3.1. So clearly the people actually building and using the nfc code don't need the DEBUG flag. Apparently using pr_debug() by setting CONFIG_DYNAMIC_DEBUG works for them. (I trust Joe will shout when that statement is incorrect.) So, as I said, the patch should be fine, and only the commit explanation needs work. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
