On Tue, Apr 28, 2015 at 07:19:02PM +0300, Kalle Valo wrote: > Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> writes: > > > Since these fmt_* variables are just const char*, and not const > > char[], gcc (and smatch) doesn't to type checking of the arguments to > > the printf functions. Since the linker knows perfectly well to merge > > identical string constants, there's no point in having three static > > pointers waste memory and give an extra level of indirection. > > > > This removes over 100 "non-constant format argument" warnings from > > smatch, accounting for about 20% of all such warnings in an > > allmodconfig. > > > > Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> > > So what's the conclusion, should I commit this patch or not? > > Full discussion here: > > https://patchwork.kernel.org/patch/5814811/ I do not see the point of the patch. If compiler behave not optimally, fix the compiler. NACK. Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
