On Mon, Apr 13, 2015 at 12:45 AM, Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> wrote: > Don't disable PS while we are not connected. > In other case we will get higher power consumption. > > Signed-off-by: Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> > --- > drivers/net/wireless/ath/ath10k/mac.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c > index 52c5b1f..b896dd4 100644 > --- a/drivers/net/wireless/ath/ath10k/mac.c > +++ b/drivers/net/wireless/ath/ath10k/mac.c > @@ -1730,7 +1730,13 @@ static int ath10k_mac_vif_setup_ps(struct ath10k_vif *arvif) > enable_ps = false; > } > > - if (enable_ps) { > + if (!arvif->is_started) { > + /* enable power save mode while not connected, > + * in other case after iface up we will get > + * higher power consumption - firmware design > + */ > + psmode = WMI_STA_PS_MODE_ENABLED; > + } else if (enable_ps) { > psmode = WMI_STA_PS_MODE_ENABLED; > param = WMI_STA_PS_PARAM_INACTIVITY_TIME; > > -- What the expectation behavior after we enable the WMI_STA_PS_MODE_ENABLED at Idle status? Is there any effect for TX or RX chain after set it? BR /Yanbo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html