Hi > > > + if (IN_DEV_CONF_GET(in_dev, DROP_UNICAST_IN_L2_MULTICAST) && > > For this flag IN_DEV_ORCONF can be used, by this way > all/drop_unicast_in_l2_multicast=1 can enable it for all > interfaces. Good point. I need to look into that for the other patches in this series as well. > So, this is the same patch as the 2014-Aug version > but this time with flag? But how the previous problems were > addressed? May be something is changed in kernel afterwards? > > So, if your are back at step 1 can you check again > the problems with this implementation?: I think I am, sorry about that. I had focused on the CLUSTERIP problem in your email, and decided that was solved by simply having the admin for CLUSTERIP networks never set this flag. > - no way to select correct skb->pkt_type in inet_rtm_getroute > before ip_route_input, this is a chiken-egg problem, of course, > skb->pkt_type = PACKET_HOST can work for now This is interesting. Why does that even build an skb and route it, if it really just cares about the struct rtable? Anyway, you're right, using PACKET_HOST would work. I'm not really sure I see the chicken-and-egg problem though, it's not like the result of this is used to route the skb again or something, afaict? > - ip_route_input is called also for ARP, so incoming ARP > broadcasts are not replied anymore Hm. I didn't see this in my testing so far, but I only enable this temporarily, so perhaps by that time it was already done. This looks like another case of using this function to not really route anything but to just look up the route, similar to the inet_rtm_getroute() function you pointed out. Perhaps that would warrant splitting out somewhat. On the other hand, there's not all that much reason not to put this into ip_rcv_finish(), we already touch the rt->rt_type there for MIB counters. I'll look into that. > - CLUSTERIP See above. Thanks, johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
