Search Linux Wireless

Re: [PATCH 2/4] mac80211-hwsim: remove dmesg spam about get-survey.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/03/2015 02:29 PM, Joe Perches wrote:
> On Fri, 2015-04-03 at 14:13 -0700, greearb@xxxxxxxxxxxxxxx wrote:
>> This message just fills up dmesg and/or kernel logs and does
>> not provide any useful information.
> []
>> diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c
> []
>> @@ -1696,7 +1696,7 @@ static int mac80211_hwsim_get_survey(
>>  {
>>  	struct ieee80211_conf *conf = &hw->conf;
>>  
>> -	wiphy_debug(hw->wiphy, "%s (idx=%d)\n", __func__, idx);
>> +	/* wiphy_debug(hw->wiphy, "%s (idx=%d)\n", __func__, idx); */
> 
> It's better, if it's really useless, to delete this
> than comment it out.
> 
> But it's not on by default anyway, so why it an issue?

It's on on my systems...rest of the wiphy debug is normally useful,
but this particular one is not and spams the logs.

I don't mind removing it entirely, but thought maybe someone would
want an easy way to enable it again for some reason.

Thanks,
Ben

-- 
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux