Search Linux Wireless

RE: [PATCH 1/3] mwifiex: add cfg80211 set_default_mgmt_key handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johannes,

Could you please check our response?
We feel set_default_key_mgmt handler is required for devices which supports 2 pair of GTKs.
How do we work around this?

Thanks,
Avinash

> -----Original Message-----
> From: Avinash Patil
> Sent: Tuesday, March 17, 2015 4:55 PM
> To: 'Johannes Berg'
> Cc: linux-wireless@xxxxxxxxxxxxxxx; Amitkumar Karwar; Cathy Luo; Xinming Hu;
> Li Long
> Subject: RE: [PATCH 1/3] mwifiex: add cfg80211 set_default_mgmt_key handler
> 
> 
> 
> > -----Original Message-----
> > From: Johannes Berg [mailto:johannes@xxxxxxxxxxxxxxxx]
> > Sent: Friday, February 13, 2015 11:37 PM
> > To: Avinash Patil
> > Cc: linux-wireless@xxxxxxxxxxxxxxx; Amitkumar Karwar; Cathy Luo;
> > Xinming Hu; Li Long
> > Subject: Re: [PATCH 1/3] mwifiex: add cfg80211 set_default_mgmt_key
> > handler
> >
> > On Thu, 2015-02-12 at 23:45 +0530, Avinash Patil wrote:
> > > From: Xinming Hu <huxm@xxxxxxxxxxx>
> > >
> > > It is observed that hostapd failed to setup with management frame
> > > protection mode enabled when using mwifiex.
> > >
> > > This is because hostapd will try to install IGTK using
> > > cfg80211 set_default_mgmt_key handler.
> > >
> > > we have already support IGTK install in set_key handler, so just
> > > work around this issue by add an empty cfg80211_set_default_mgmt_key
> handler.
> >
> > I believe that this is incorrect since the key should only be
> > installed for TX after this handler, not in the set_key handler. This
> > should make a difference in the case of rekeying? Perhaps hostapd
> > doesn't actually program the key until rekeying with all stations finishes
> though.
> 
> I believe that set_defualt_mgmt_key and corresponding changes in hostapd &
> cfg80211 are designed with focus on mac80211.
> Our design is a bit different in a way all PMF is handled in FW; also we don't
> support two pair of GTK/IGTKs.
> We already have installed IGTK to FW in add_key handler.
> 
> > johannes

��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux