Search Linux Wireless

Re: [PATCH] cfg80211: Stop calling crda if it is not responsive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2015-03-29 at 09:18 +0300, Ilan Peer wrote:
> Patch eeca9fce1d71a4955855ceb0c3b13c1eb9db27c1 (cfg80211: Schedule
> timeout for all CRDA call) introduced a regression, where in case
> that crda is not installed (or not configured properly etc.), the
> regulatory core will needlessly continue to call it.

And print a message, which was the complaint :)

> @@ -544,6 +549,11 @@ static int call_crda(const char *alpha2)
>  	/* query internal regulatory database (if it exists) */
>  	reg_regdb_query(alpha2);
>  
> +	if (reg_crda_timeouts > REG_MAX_CRDA_TIMEOUTS) {
> +		pr_info("Exceeded CRDA call max attempts. Not calling CRDA\n");
> +		return -EINVAL;
> +	}

and won't this just trade one message for another??

Or in fact, duplicate messages - 'calling crda' followed by 'exceeded'?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux