Hi James, > -----Original Message----- > From: James Cameron [mailto:quozl@xxxxxxxxxx] > Sent: Monday, March 23, 2015 4:42 PM > To: Avinash Patil > Cc: linux-wireless@xxxxxxxxxxxxxxx; Amitkumar Karwar; Cathy Luo; Zhaoyang Liu > Subject: Re: [PATCH 2/2] mwifiex: recover from skb allocation failures during > RX > > > On 24/03/2015, at 1:20 AM, Avinash Patil wrote: > > > From: Zhaoyang Liu <liuzy@xxxxxxxxxxx> > > > > This patch adds recovery mechanism for SDIO RX during SKB allocation > > failures. > > For allocation failures during multiport aggregation, we skip and drop > > RX packets. > > For single port read case, we will use preallocated card->mpa_rx.buf > > to complete cmd53 read. > > Thanks. > > Dropping RX data packets is considered safe, as the peer will retry; but does > your patch drop events or command responses? > > Last year, I tried something similar, and I found that the driver would be > confused if command responses were dropped. RX packets only would be dropped after SKB allocation failures. Command response/events continue to have same handling as earlier. > -- > James Cameron -Avinash -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
