Search Linux Wireless

Re: [PATCH] iwlwifi: Fix memory leak in iwl_req_fw_callback()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2015-03-23 at 14:07 -0500, Larry Finger wrote:
> In this routine, kzalloc allocates a memory block. This allocation is
> freed in the error paths, but not in the normal exit, thus the allocation
> is leaked.
> 
> The kmemleak facility was used to find the leak.
> 

Picked up - thanks.

> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> Cc: Johannes Berg <johannes.berg@xxxxxxxxx>
> Cc: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx>
> Cc: Intel Linux Wireless <ilw@xxxxxxxxxxxxxxx>
> ---
>  drivers/net/wireless/iwlwifi/iwl-drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/iwlwifi/iwl-drv.c b/drivers/net/wireless/iwlwifi/iwl-drv.c
> index 66ca000..aefdd9b 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-drv.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-drv.c
> @@ -1319,6 +1319,7 @@ static void iwl_req_fw_callback(const struct firmware *ucode_raw, void *context)
>  				op->name, err);
>  #endif
>  	}
> +	kfree(pieces);
>  	return;
>  
>   try_again:

��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux