Joe Perches <joe@xxxxxxxxxxx> writes:
> On Mon, 2015-03-23 at 16:25 -0400, Jes.Sorensen@xxxxxxxxxx wrote:
>> From: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx>
>>
>> This is an alternate driver for the Realtek 8723AU (rtl8723au) written
>> from scratch utilizing the mac80211 stack.
>
> trivia:
>
>> diff --git a/drivers/net/wireless/rtl8xxxu.c b/drivers/net/wireless/rtl8xxxu.c
> [
>> +#define USB_VENDER_ID_REALTEK 0x0BDA
>
> realtek can't spell. VENDOR
Rather minor, but sure, I'll fix that up.
>> +/* Minimum IEEE80211_MAX_FRAME_LEN */
>> +#define RTL_RX_BUFFER_SIZE IEEE80211_MAX_FRAME_LEN
>> +
>> +static struct usb_device_id dev_table[] = {
>
> const
>
>> + {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDER_ID_REALTEK, 0x8724,
>> + 0xff, 0xff, 0xff)},
>> + {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDER_ID_REALTEK, 0x1724,
>> + 0xff, 0xff, 0xff)},
>> + {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDER_ID_REALTEK, 0x0724,
>> + 0xff, 0xff, 0xff)},
>> + { }
>> +};
>
>> +static int rtl8xxxu_read_efuse(struct rtl8xxxu_priv *priv)
>> +{
>
> []
>
>> + while (efuse_addr < EFUSE_REAL_CONTENT_LEN_8723A) {
>> + ret = rtl8xxxu_read_efuse8(priv, efuse_addr++, &header);
>> + if (ret || header == 0xff)
>> + goto exit;
>
> break and no exit label would be more common
>
> []
>
>> +exit:
>> + rtl8723au_write8(priv, REG_EFUSE_ACCESS, EFUSE_ACCESS_DISABLE);
>> +
>> + if (priv->efuse_wifi.efuse.rtl_id != cpu_to_le16(0x8129))
>> + ret = EINVAL;
>
> -EINVAL
This needs to be fixed, however the return code isn't actually checked
at present, which is a bigger issue. It's a highly unlikely error
condition, so it can easily be fixed in a follow-on patch.
>> +static bool rtl8xxxu_simularity_compare(struct rtl8xxxu_priv *priv,
>> + int result[][8], int c1, int c2)
>
> Looking through git history, simularity seems to be used
> because realtek can't spell.
It might be the case, but until I see some actual evidence of this, I am
not going to spend cycles on it. It's hardly something justifying the
patch noise in the first place.
Jes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
