On 22 March 2015 at 08:49, Arik Nemtsov <arik@xxxxxxxxxx> wrote: > On Fri, Mar 20, 2015 at 1:02 PM, Marek Puzyniak > <marek.puzyniak@xxxxxxxxx> wrote: >> As a part of tdls implementation introduce >> tdls related wmi data structures, constant >> values and functions. >> >> Signed-off-by: Marek Puzyniak <marek.puzyniak@xxxxxxxxx> >> --- >> drivers/net/wireless/ath/ath10k/wmi-ops.h | 42 ++++++++ >> drivers/net/wireless/ath/ath10k/wmi-tlv.c | 153 ++++++++++++++++++++++++++++++ >> drivers/net/wireless/ath/ath10k/wmi-tlv.h | 53 +++++++++++ >> drivers/net/wireless/ath/ath10k/wmi.h | 37 ++++++++ >> 4 files changed, 285 insertions(+) > [...] >> + >> + cmd = (void *)tlv->value; >> + cmd->vdev_id = __cpu_to_le32(vdev_id); >> + cmd->state = __cpu_to_le32(state); >> + cmd->notification_interval_ms = __cpu_to_le32(5000); >> + cmd->tx_discovery_threshold = __cpu_to_le32(100); >> + cmd->tx_teardown_threshold = __cpu_to_le32(5); >> + cmd->rssi_teardown_threshold = __cpu_to_le32(-75); >> + cmd->rssi_delta = __cpu_to_le32(-20); >> + cmd->tdls_options = __cpu_to_le32(options); >> + cmd->tdls_peer_traffic_ind_window = __cpu_to_le32(2); >> + cmd->tdls_peer_traffic_response_timeout_ms = __cpu_to_le32(5000); >> + cmd->tdls_puapsd_mask = __cpu_to_le32(0xf); >> + cmd->tdls_puapsd_inactivity_time_ms = __cpu_to_le32(0); >> + cmd->tdls_puapsd_rx_frame_threshold = __cpu_to_le32(10); > > Do the above lines assume all TDLS peers support TDLS buffer-sta > (which is required for peer UAPSD)? Especially the value of > tdls_puapsd_mask. > I can assure you not all peers support this :) For instance iwlwifi > does not (for now). > > But I might be misinterpreting this - perhaps there some other code in > the driver/FW that checks the peer's extended-capabilities IE for > buffer-sta support (bit 28)? > That would be the best option. ath10k doesn't support buffer-sta as well. Firmware requires additional tdls_options flags (WMI_TLV_TDLS_BUFFER_STA_EN and WMI_TLV_TDLS_SLEEP_STA_EN) to be set before it considers these values. Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
