Michal Kazior <michal.kazior@xxxxxxxxx> writes: >> When I was adding WMI_OP_VERSION, my idea was that we will add similar >> version for HTT as well once we need it. But I guess this is good enough >> for now, we can add HTT_OP_VERSION later if more changes are needed. > > Maybe it should be renamed to OP_VERSION (drop the WMI_) or BRANCH_ID > or something else? > > It's not like HTT wasn't diverging. It was. However only WMI ABI was > seeing major breakage that needed taking care of. HTT changes were > small enough and could be ignored until now. I'm a bit worried that having one id for everything will be more difficult to maintain, that's why I created WMI_OP_VERSION in the first place. IMHO it's lot cleaner codewise to have one id for WMI interface and one id for HTT (eg. HTT_OP_VERSION). What do you think? > Perhaps the rename could be accompanied by FW API bump to 5? Maybe not the rename, but yeah, something should be decided before the bump up. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html