On 2015-03-14 01:21, Sujith Manoharan wrote: > Kalle Valo wrote: >> With these patches I got a new warning: >> >> drivers/net/wireless/ath/ath9k/ar9003_aic.c: In function 'ar9003_aic_cal_post_process': >> drivers/net/wireless/ath/ath9k/ar9003_aic.c:431:1: warning: the frame size of 1312 bytes is larger than 1024 bytes [-Wframe-larger-than=] >> >> Is it a valid warning? > > When CONFIG_FRAME_WARN is set to 1024, this will be hit. > On my machine, the value is 2048, so the stack doesn't overflow. > > But, 1024 could be a valid limit in some architectures, so I'll > rework ar9003_aic_cal_post_process() to avoid using the stack > excessively and post another series. It's probably enough to just change struct ath_aic_sram_info to make it fit: Just put the bool fields together and make them single-bit. This should save more than 300 bytes. - Felix -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
