Hi, > -----Original Message----- > From: Bjørn Mork [mailto:bjorn@xxxxxxx] > Sent: Thursday, March 12, 2015 6:38 PM > To: Avinash Patil > Cc: linux-wireless@xxxxxxxxxxxxxxx; Amitkumar Karwar; Cathy Luo; Zhaoyang Liu; > Chin-Ran Lo; Plus Chen; Shengzhen Li; Nishant Sarmukadam > Subject: Re: [PATCH 3/9] mwifiex: enhance SD8897 MP aggregation limits > > Avinash Patil <patila@xxxxxxxxxxx> writes: > > > diff --git a/drivers/net/wireless/mwifiex/sdio.h > > b/drivers/net/wireless/mwifiex/sdio.h > > index c636944..5a23bd0 100644 > > --- a/drivers/net/wireless/mwifiex/sdio.h > > +++ b/drivers/net/wireless/mwifiex/sdio.h > > @@ -67,6 +67,7 @@ > > > > #define MWIFIEX_MP_AGGR_BUF_SIZE_16K (16384) > > #define MWIFIEX_MP_AGGR_BUF_SIZE_32K (32768) > > +#define MWIFIEX_MP_AGGR_BUF_SIZE_64K (65280) > > The first two macros are clearly matching their 16K and 32K names, but the 64K > one is not. Care to add a comment explaining where the missing > 256 bytes went? We reserve first block of 256 bytes for DMA alignment. I will add a comment to definition; also rename define since it is not exactly 64K. > Bjørn (always curious about surprising numbers :-) -Avinash ��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f