On Thu, Mar 12, 2015 at 03:21:34PM +0200, Kalle Valo wrote: > Rajkumar Manoharan <rmanohar@xxxxxxxxxxxxxxxx> writes: > > > On Tue, Mar 10, 2015 at 05:43:58PM +0200, Kalle Valo wrote: > >> Rajkumar Manoharan <rmanohar@xxxxxxxxxxxxxxxx> writes: > >> > >> > Add support to configure quiet period via sysfs entry. This will > >> > be helpful to experiment different quiet period values along with > >> > different duty cycle ratio. > >> > > >> > To configure quiet period as 30ms, > >> > > >> > echo 30 >/sys/class/ieee80211/phyX/device/quiet_period > >> > >> What's the justification? To me this looks like an ugly driver private > >> hack. Why can't you use nl80211 or something else? > > > > As this is purely for testing purpose to play around with different > > quiet period along with various throttling state, sysfs entry is used > > instead of netlink testmode command. Instead of debugfs, sysfs entry is > > selected to align with existing thermal interface. > > Please correct me if I'm wrong, but I consider sysfs as a stable user > space interface. It's not meant for random testing stuff. > Completely agree. Will move this change under debugfs. Does it sound good? -Rajkumar -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
