On 10/03/2015 12:58, Stepanov, Max wrote: >> From: Cedric Izoard <Cedric.Izoard@xxxxxxxxxxxx> >> To: linux-wireless@xxxxxxxxxxxxxxx <linux-wireless@xxxxxxxxxxxxxxx> >> Cc: johannes@xxxxxxxxxxxxxxxx <johannes@xxxxxxxxxxxxxxxx> >> Subject: [PATCH] mac80211: Get IV len from key conf and not cipher >> scheme >> Date: Tue, 10 Mar 2015 08:52:23 +0000 >> >> Do not always dereference sta to get cipher scheme as it may be null >> for broadcast messages. >> Instead get IV length from key configuration which has been >> initialized with cipher scheme. >> > Cedric, in general a cipher scheme was about to be used with a station holding ucast and mcast/bcast keys, so, my question is about the following line: > >> + res = ieee80211_crypto_cs_encrypt(tx, skb); > What is a point of calling this function when tx->key->sta or tx->key->sta->cipher_scheme is NULL? In which scenario? > > Thanks, > Max > Hi, We use cipher scheme to support WAPI in both STA and AP mode. The patch is for the AP use case when sending a broadcast message that needs encryption. So we want to call ieee80211_crypto_cs_encrypt even if sta is NULL. rgds, cedric -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
