On 3 March 2015 at 13:14, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote:
> Rafał Miłecki <zajec5@xxxxxxxxx> writes:
>
>> Signed-off-by: Rafał Miłecki <zajec5@xxxxxxxxx>
>
> Please, no empty commit logs. I don't (yet) require that with all
> patches, but this definitely needs one. Is this ok:
>
> bcma: add missing includes
>
> kbuild found out that commit 804e27dee49e ("bcma: support bringing up
> bus hosted on PCIe Gen 2") broke the build on m68k:
>
> drivers/bcma/driver_pcie2.c: In function 'bcma_core_pcie2_up':
>>> drivers/bcma/driver_pcie2.c:196:2: error: implicit declaration of function 'pcie_set_readrq' [-Werror\
> =implicit-function-declaration]
> err = pcie_set_readrq(dev, pcie2->reqsize);
> ^
> cc1: some warnings being treated as errors
>
> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> Signed-off-by: Rafał Miłecki <zajec5@xxxxxxxxx>
You're right, I could to better :| Yes, your version looks OK.
--
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
