Re: [patch] rtlwifi: rtl8188ee: missing curly braces in handle_branch1()

[Larry Finger <Larry.Finger@xxxxxxxxxxxx>]

On 02/25/2015 07:24 AM, Dan Carpenter wrote:
> > From the indenting, it seems like the READ_NEXT_PAIR() was supposed to
> be inside the while loop.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Good catch.

Acked-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>

Thanks,

Larry

> diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c b/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c
> index 3f6c59c..a2bb02c 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c
> @@ -452,9 +452,10 @@ static void handle_branch1(struct ieee80211_hw *hw, u16 arraylen,
>   				READ_NEXT_PAIR(v1, v2, i);
>   				while (v2 != 0xDEAD &&
>   				       v2 != 0xCDEF &&
> -				       v2 != 0xCDCD && i < arraylen - 2)
> +				       v2 != 0xCDCD && i < arraylen - 2) {
>   					_rtl8188e_config_bb_reg(hw, v1, v2);
>   					READ_NEXT_PAIR(v1, v2, i);
> +				}
>
>   				while (v2 != 0xDEAD && i < arraylen - 2)
>   					READ_NEXT_PAIR(v1, v2, i);

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html