Hi, For the TX path, I don't think a memmove() of the header further down is really expensive, it should be within the CPU cache since we operate on the skb header a lot. However, you'd have to undo that too before TX status reporting to get radiotap working properly :/ > I agree, but overall I think this would mean for rt2x00 it will be easier to stop > sending the skb->data directly to the USB host and use the preallocated DMA > instead. > Especially the RX path could benefit since otherwise it will be continuously using > memmove on the header and payload to insert the IV and have the payload 4-byte aligned. How would you go about handling out-of-band IV in the RX path? In the TX path, I can see how you could do that, but in RX? In any case, if you can make usable patches for out-of-band IV I'm not totally against it, but I'd like to keep the overhead as low as possible. In particular, I was thinking of embedding tx_conf into skb->cb[] so you wouldn't have space in there for the IV. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
