On 02/06/2015 07:56 AM, Kalle Valo wrote:
> Rafał Miłecki <zajec5@xxxxxxxxx> writes:
>
>>>> +void bcma_core_pcie2_up(struct bcma_drv_pcie2 *pcie2)
>>>> +{
>>>> + struct bcma_bus *bus = pcie2->core->bus;
>>>> + struct pci_dev *dev = bus->host_pci;
>>>> +
>>>> + pcie_capability_clear_and_set_word(dev, PCI_EXP_DEVCTL,
>>>> + PCI_EXP_DEVCTL_READRQ,
>>>> + pcie2->reqsize);
>>>
>>> Use pcie_set_readrq() if it is needed.
>>
>> What do you mean by "if needed"? Is there anything wrong?
>
> So what's the conclusion? Can I apply these?
>
Ah sorry,
The "if needed" referenced the comment above about if setting this is
needed at all, or if this should be done by the driver for the (broken?)
PCIe controller.
pcie_set_readrq() does the setting of this register in the Linux kernel
and does some additional checks, I would suggest using this function
instead of setting this register by yourself.
Hauke
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
