On Fri, 6 Feb 2015 09:58:46 +0100, Jakub Kiciński wrote: > On Fri, 30 Jan 2015 16:14:30 -0800, Peter Oh wrote: > > Using ioread() to perform draining write buffer is excessive. > > Use compact API, mb(), that intended to be used for the case. > > It reduces total 14 CPU clocks per interrupt. > > > > Signed-off-by: Peter Oh <poh@xxxxxxxxxxxxxxxx> > > I have no idea what the code does but this change looks suspicious. > Usually the point of ioread() is to flush the interconnect buffers > while mb() ensures ordering only from the CPU perspective. > > Could you provide the reason *why* flushing buffers is unnecessary > in the commit message? I just noticed the discussion on the first version of the patch. Sorry about the noise. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
