On 4/4/08, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > > + * This function must be called by low level driver to inform mac80211 of > > + * low level driver status change or force mac80211 to re-assoc for low > > + * level driver internal error that require re-assoc. A good example to use > > + * this notification to call mac80211 after suspend/resume, some NIC require > > + * re-assoc. > > I think the suspend/resume text should be dropped since IMHO that > requires more work, reprogramming all the hardware crypto keys for > example. I can remove the suspend/resume text will be that good enough? > > > + /* No need to wake the master device. */ > > + if (sdata->dev == local->mdev) > > + continue; > > That looks like a copy&paste bug, we're not waking it in any way. Also, > it's of IF_TYPE_AP so it's not necessary to test this at all. > you are right it is a copy&paste from other part in mac80211, but as you mentioned this an extra filtering which is not needed. I will remove it and resubmit again. > johannes > > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
