On 01/28/2015 11:57 PM, Michal Kazior wrote: > On 29 January 2015 at 02:32, YanBo <dreamfly281@xxxxxxxxx> wrote: >> Hi Michal, >> >> What the conclusion about this patch, it looks like this patch not be >> merged into ath10K due to introduce some unstable issue, I'v got >> another issue that when move the station enter hibernate mode. the AP >> will continue report message like before >> [ 3958.681293] ath10k_pci 0000:01:00.0: Spurious quick kickout for STA >> 00:03:7f:40:04:5b >> [ 3959.681449] ath10k_pci 0000:01:00.0: Spurious quick kickout for STA >> 00:03:7f:40:04:5b >> [ 3960.681696] ath10k_pci 0000:01:00.0: Spurious quick kickout for STA >> 00:03:7f:40:04:5b >> [ 3961.681877] ath10k_pci 0000:01:00.0: Spurious quick kickout for STA >> 00:03:7f:40:04:5b >> [ 3962.682080] ath10k_pci 0000:01:00.0: Spurious quick kickout for STA >> 00:03:7f:40:04:5b >> [ 3963.682361] ath10k_pci 0000:01:00.0: Spurious quick kickout for STA >> 00:03:7f:40:04:5b >> [ 3964.682550] ath10k_pci 0000:01:00.0: Spurious quick kickout for STA >> 00:03:7f:40:04:5b >> [ 3965.682743] ath10k_pci 0000:01:00.0: Spurious quick kickout for STA >> 00:03:7f:40:04:5b > > The spurious STA kickout alone is most likely an aftermath of HTX Tx > credit starvation when client was detected as inactive by hostapd and > was subsequently disassociated. However due to starvation > wmi-peer-delete was never sent to firmware so fw thinks the peer is > still there. > > I suppose fw should be restarted when ath10k is unable to submit a > configuration command like wmi-peer-delete. It doesn't make sense to > continue since fw-host state loses coherency and weird things can > start to happen (spurious sta kickout is the best known example). At least some of the tx-credits problem is in firmware, but regardless of that: Instead of restarting firmware in this case, maybe change the 'wait-for-3-seconds' timeout to 3 1-second timeouts, and on second timeout force a flush, ignoring tx-credits if required? That may not be pretty, but seems better than resetting firmware if it works. Thanks, Ben -- Ben Greear <greearb@xxxxxxxxxxxxxxx> Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
