Sedat Dilek <sedat.dilek@xxxxxxxxx> writes:
> On Sat, Jan 24, 2015 at 12:34 PM, Hong Xu <hong@xxxxxxxxxx> wrote:
>> ath9k and ath9k_htc use the variable name "led_blink" to indicate
>> whether the module parameter "blink" is on. This name is easy to
>> conflict with other variables, and has caused a compiler error found
>> by kbuild test bot. The compiler error is as following:
>>
>> drivers/net/wireless/ath/ath9k/ath9k_htc.o:(.data+0x47c): multiple definition of `led_blink'
>> drivers/net/wireless/ath/ath9k/ath9k.o:(.bss+0x20): first defined here
>>
>> Fixes: 3a939a671225 ("ath9k_htc: Add a module parameter to disable blink")
>> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
>> Signed-off-by: Hong Xu <hong@xxxxxxxxxx>
>> ---
>> Compared to previous versions, the commit message is improved to fit
>> the contribution guideline (again).
>> ---
>
> This looks good.
> ( As said please have a look at [1]. )
>
> I have one thing for followers of (linux-wireless) mailing-lists in general.
> If your patch is against a special Git tree, please add a
> "subject-prefix" and/or put a note in the commit-body.
> For example: "This patch is against wireless-drivers-next or
> linux-next (next-2015-01-23)."
> This is very helpful.
> Think also of patches listed and downloadable from patchwork-service [2].
>
> $ git format-patch --subject-prefix="PATCH wireless-drivers-next" ...
>
> ( Maybe w-d-n or w-d-next is a good abbreviation :-). )
>
> - Sedat -
>
> [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches
> [2] https://patchwork.kernel.org/project/linux-wireless/list/
Thanks, Sedat. I'll be more careful next time :)
Hong
Attachment:
signature.asc
Description: PGP signature
