On Sat, Jan 24, 2015 at 12:10 PM, Hong Xu <hong@xxxxxxxxxx> wrote:
>
> Sedat Dilek <sedat.dilek@xxxxxxxxx> writes:
>
>> On Sat, Jan 24, 2015 at 11:23 AM, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote:
>>> Hong Xu <hong@xxxxxxxxxx> writes:
>>>
>>>> ath9k and ath9k_htc use the variable name "led_blink" to indicate
>>>> whether the module parameter "blink" is on. This name is easy to
>>>> conflict with other variables, thus they are renamed.
>>>
>>> Please state clearly that this fixes a compiler error found by kbuild.
>>> Also it's very much recommended to add the actual compiler error to the
>>> commit log:
>>>
>>> drivers/net/wireless/ath/ath9k/ath9k_htc.o:(.data+0x47c): multiple definition of `led_blink'
>>> drivers/net/wireless/ath/ath9k/ath9k.o:(.bss+0x20): first defined here
>>>
>>
>> Some more things...
>>
>> If you post a vN (referring to your v3) of a patch, please add a
>> history of changes.
>>
>> 2nd, use the Fixes tag [2] in this case with a reference to the
>> culprit commit [1].
>>
>> Fixes: 3a939a671225 ("ath9k_htc: Add a module parameter to disable blink")
>>
>> Last but not least, honour credits like Reported-by/Tested-by (plus
>> some infos like broken in Linux-next $VERSION).
>>
> Thanks for your comments, I should have been more careful with the
> guideline. I guess we shouldn't credit kbuild for reporting in this case?
>
Learning by doing :-).
Yesterday, I looked trough some Git trees offline and I saw a commit
with kbuild-test-bot as "author", so... :-).
Not sure, if this is good, but I would prefer to put a note in the
commit-body (some call it changelog, I refer to terms in email
context)... "...found by kbuild test bot" with appropriate lines of
warning.
( See example in [1]. )
- Sedat -
[1] http://www.spinics.net/lists/linux-usb/msg110760.html
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
