Search Linux Wireless

Re: [RFC iw next] phy: Allow set netns by fd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 23, 2015 at 04:34:27PM +0100, Johannes Berg wrote:
> On Fri, 2015-01-23 at 17:13 +0200, Vadim Kochan wrote:
> > From: Vadim Kochan <vadim4j@xxxxxxxxx>
> > 
> > Added possibility to change network namespace
> > for phy device by network namespace name from
> > /var/run/netns or by absolute file path:
> > 
> >     iw phy XXX set netns <nsname> | <pid>
> > 
> > First iw tries to find given nsname from /var/run/netns
> > or by absoute path (in case if nsname contains "/") and if
> > it failed to open nsname file then iw uses given argument as <pid>.
> 
> Hmm. I think it'd be better to do something like
> 
> iw phy XXX set netns name <nsname>
> 
> That way there's no way it can be a valid PID.
> 
> Otherwise, if you happen to have a file in your local directory that's
> the name of the PID you want, weird things happen.
> 
> > Also added missing NL80211 attributes before NL80211_CMD_SET_WIPHY_NETNS.
> 
> Please don't - I'll update nl80211.h by copying as needed.
> 
> johannes
> 

OK, just to clarify with nl80211.h - you will update it including new
NL80211_ATTR_NETNS_FD ? If yes - I will wait for this change.

Thanks,
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux