Andy Green <andy.green@xxxxxxxxxx> writes: > On 18 January 2015 at 22:17, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: >> Andy Green <andy.green@xxxxxxxxxx> writes: n>> >>> Convert the list of chip types to an enum, add the default >>> UNKNOWN type and a type for WCN3620 chip >>> >>> Signed-off-by: Andy Green <andy.green@xxxxxxxxxx> >> >> Please just use "wcn36xx: ", you should drop "net: wireless: " entirely. > > OK. > > Can you help me understand what you'd like to see happen with the chip > variant detection stuff? I haven't looked at wcn36xx for a long time so I'm not really the right person to answer. I'm more like a desk jockey now ;) > There's a comment sent to one list only saying it might be preferable > to keep the old detection code as the default. But there are no > in-tree users of wcn36xx (mainly due to PIL not being in mainline, I > guess). > > The old test's equivalence that AC == 3680 seems kind of weak to me > and establishing the type must be passed in from platform code > reflects the situation that there's no public way to detect the chip > type from Qualcomm. In the second not-for-upstream series I use that > to pass it in from DT, which is how it'd be normally used. Please remember that the DT bindings document has to be acked by the device-tree maintainers. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
