On 01/22/2015 03:01 PM, Kalle Valo wrote: > Hauke Mehrtens <hauke@xxxxxxxxxx> writes: > >> On 01/16/2015 08:59 PM, Rafał Miłecki wrote: >>> This moves main bus init code to the main.c and renames old function to >>> make its purpose clear. >>> Thanks to this change we'll also be able to separate scanning from >>> registration (and support PCIe Gen 2 devices) in the future. >>> >>> Signed-off-by: Rafał Miłecki <zajec5@xxxxxxxxx> >> >> Signed-off-by: Hauke Mehrtens <hauke@xxxxxxxxxx> > > No need to change anything now, but I think that in cases like this you > should use Acked-by: > > "13) When to use Acked-by: and Cc: > > The Signed-off-by: tag indicates that the signer was involved in the > development of the patch, or that he/she was in the patch's delivery > path. > > If a person was not directly involved in the preparation or handling > of a patch but wishes to signify and record their approval of it then > they can arrange to have an Acked-by: line added to the patch's > changelog. > > Acked-by: is often used by the maintainer of the affected code when > that maintainer neither contributed to nor forwarded the patch." > > Yes you are right I thought about that right after I send clicked on send. Sorry. Hauke -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
