Search Linux Wireless

Re: [PATCH] brcmfmac: Use put_unaligned_le32

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 15, 2015 at 6:30 PM, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote:
> Vaishali Thakkar <vthakkar1994@xxxxxxxxx> writes:
>
>> This patch introduces the use of function put_unaligned_le32.
>>
>> This is done using Coccinelle and semantic patch used is as follows:
>>
>> @a@
>> typedef u32, __le32, uint32_t;
>> {u32,__le32,uint32_t} e32;
>> identifier tmp;
>> expression ptr;
>> expression y,e;
>> type T;
>> type T;
>> @@
>>
>> - tmp = cpu_to_le32(y);
>>
>> <+... when != tmp
>> (
>> - memcpy(ptr, (T)&tmp, \(4\|sizeof(u32)\|sizeof(__le32)\|sizeof(uint32_t)\|s
>> + put_unaligned_le32(y,ptr);
>> |
>> - memcpy(ptr, (T)&tmp, ...);
>> + put_unaligned_le32(y,ptr);
>> )
>> ...+>
>> ? tmp = e
>>
>> @@ type T; identifier a.tmp; @@
>>
>> - T tmp;
>> ...when != tmp
>>
>> Signed-off-by: Vaishali Thakkar <vthakkar1994@xxxxxxxxx>
>
> This failed to apply, please rebase:
>
> Applying: brcmfmac: Use put_unaligned_le32
> error: drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c: does not exist in index
> Patch failed at 0001 brcmfmac: Use put_unaligned_le32
>

Yes. Sorry. Because of some technical problems with my machine, I
couldn't be able to send new patch as I didn't have code with me.
Actually I sent follow up mail to John about dropping this patch
[about 6 days back] until I rebase it. But forgot to cced it to
mailing list. I will send rebased patch.

Sorry again.

> --
> Kalle Valo



-- 
Vaishali
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux