Michal Kazior <michal.kazior@xxxxxxxxx> writes: > On 12 January 2015 at 13:56, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote: >>> Signed-off-by: Michal Kazior <michal.kazior@xxxxxxxxx> > [...] >>> void ath10k_print_driver_info(struct ath10k *ar) >>> { >>> - ath10k_info(ar, "%s (0x%08x, 0x%08x) fw %s api %d htt %d.%d wmi %d cal %s max_sta %d\n", >>> + ath10k_info(ar, "%s (0x%08x, 0x%08x) fw %s api %d htt %d.%d wmi %d cal %s max_sta %d build %u.%u.%u.%u\n", > [...] >> >> So now we print two different firmware versions to the user? That's just >> confusing. It's ok to print this build id in debug level, but not in >> info level. From user's point of view we should have only one firmware >> version. > > I guess we shouldn't be printing htt version then too. Nevertheless I > understand your concern. Yeah, but htt version is an interface version and I'm having a hard time to believe that someone will mistake that as the actual firmware version. But what people confuse is the FW API version. When I ask what firmware version you have way too often I get "firmware-3.bin" as a reply :) But I have no ideas how to solve that. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html