On Wed, Jan 7, 2015 at 3:50 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Wed, 2015-01-07 at 15:48 +0200, Arik Nemtsov wrote: >> > >> >> > >> >> >> > Also, the only reason this can happen anyway is when you call "can >> >> >> > beacon" for a station interface - which seems nonsensical. Given that >> >> >> >> >> >> This is not true. This happens with current code for a p2p-go >> >> >> interface during channel validity checks in reg.c. >> >> > >> >> > Not sure I see this? The only thing doing wdev locking is >> >> > cfg80211_go_permissive_chan(), no? And that only for station interfaces. >> >> >> >> cfg80211_go_permissive_chan is called from cfg80211_reg_can_beacon, >> >> currently only for GO interfaces, but for STA also in the future >> >> (hopefully). >> >> The latter is called during channel validity checks for GO. >> > >> > Ok. >> > >> > Should I just apply the patch as it is then? >> >> It fixes a real existing deadlock, so I think so, yea. > > Is it needed on 3.19? Yes, since the channel validity checking is already there. Basically everyone that sets up a GO and has some regulatory change afterwards might deadlock.. Arik -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
